Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

js: Break cyclic dependency between unread_ops and recent_topics_ui. #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

js: Break cyclic dependency between unread_ops and recent_topics_ui. #21

wants to merge 1 commit into from

Conversation

sbansal1999
Copy link
Owner

@sbansal1999 sbansal1999 commented Apr 8, 2023 •
edited
Loading

This commits breaks the cyclic dependency between unread_ops.js and recent_topics_ui.js.

It achieves this by passing the update_topic function through the function calls in server_events_dispatch.js, hence avoiding the need of importing recent_topics_ui.js.

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@sbansal1999 sbansal1999 force-pushed the cyclic_dep_length_1 branch 4 times, most recently from 710e85e to 76bdb12 Compare April 9, 2023 06:12
@sbansal1999
js: Break cyclic dependecny between unread_ops and recent_topics_ui.
9d27119 
This commits breaks the cyclic dependency between "unread_ops.js"
and "recent_topics_ui.js" by passing the "update_topic" function
through the function calls in "server_events_dispatch.js", hence
avoiding the need of importing "recent_topics_ui.js"
@sbansal1999 sbansal1999 changed the title js: Break cyclic dependecny between unread_ops and recent_topics_ui. js: Break cyclic dependency between unread_ops and recent_topics_ui. Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sbansal1999